fix: 🐛 image shape is not rendering in iTerm

Control code that is used for ending inline image sequence in iTerm turns out to be wrong. This commit fixes the code and now images can be shown in iTerm again.
ghaiklor · May 11, 2020 · c9b0942 · c9b0942
1 parent e6c6dd9
commit c9b0942
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/kittik-shape-image/spec/Image.spec.ts b/packages/kittik-shape-image/spec/Image.spec.ts
@@ -37,7 +37,7 @@ describe('image shape', () => {
 
     expect(writeSpy).toHaveBeenCalledTimes(1);
     expect(writeSpy).toHaveBeenCalledWith(
-      '\u001b[11;11H\u001b]1337;File=size=6;width=15;height=5;preserveAspectRatio=1;inline=1:dGVzdA==^G'
+      '\u001b[11;11H\u001b]1337;File=size=6;width=15;height=5;preserveAspectRatio=1;inline=1:dGVzdA==\u0007'
     );
   });
 
@@ -59,7 +59,7 @@ describe('image shape', () => {
 
     expect(writeSpy).toHaveBeenCalledTimes(1);
     expect(writeSpy).toHaveBeenCalledWith(
-      '\u001b[11;11H\u001b]1337;File=size=6;width=15;height=5;preserveAspectRatio=0;inline=1:dGVzdA==^G'
+      '\u001b[11;11H\u001b]1337;File=size=6;width=15;height=5;preserveAspectRatio=0;inline=1:dGVzdA==\u0007'
     );
   });
 

diff --git a/packages/kittik-shape-image/src/Image.ts b/packages/kittik-shape-image/src/Image.ts
@@ -67,7 +67,7 @@ export class Image extends Shape implements ImageOptions, ShapeRenderable {
       'inline=1'
     ].join(';');
 
-    canvas.stream.write(`\u001b[${y + 1};${x + 1}H\u001b]1337;File=${args}:${image}^G`);
+    canvas.stream.write(`\u001b[${y + 1};${x + 1}H\u001b]1337;File=${args}:${image}\u0007`);
   }
 
   public toObject (): ImageObject {