fix: 🐛 issue with animating text with print animation

ghaiklor · Mar 26, 2020 · b55f6bd · b55f6bd
1 parent 5055370
commit b55f6bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/src/kittik-shape-fig-text/spec/FigText.spec.ts b/src/kittik-shape-fig-text/spec/FigText.spec.ts
@@ -103,7 +103,8 @@ describe('Shape::FigText', () => {
 
     expect(shape).toBeInstanceOf(FigText);
     expect(shape.cursor).toBeInstanceOf(Canvas);
-    expect(shape.text.length).toEqual(386);
+    expect(shape.text).toEqual('test');
+    expect(shape.renderedText.length).toEqual(386);
     expect(shape.x).toEqual('0');
     expect(shape.y).toEqual('0');
     expect(shape.background).toEqual('red');

diff --git a/src/kittik-shape-fig-text/src/FigText.ts b/src/kittik-shape-fig-text/src/FigText.ts
@@ -39,20 +39,16 @@ export class FigText extends Shape implements FigTextOptions, ShapeRenderable {
   }
 
   get width (): string {
-    const lengths = this.text.split('\n').map(item => item.length);
+    const lengths = this.renderedText.split('\n').map(item => item.length);
     return Math.max(...lengths).toString();
   }
 
   get height (): string {
-    return this.text.split('\n').length.toString();
+    return this.renderedText.split('\n').length.toString();
   }
 
-  set text (text: string) {
-    this._text = text;
-  }
-
-  get text (): string {
-    return figlet.textSync(this._text, {
+  get renderedText (): string {
+    return figlet.textSync(this.text, {
       font: this.font,
       horizontalLayout: this.horizontalLayout,
       verticalLayout: this.verticalLayout,
@@ -63,7 +59,7 @@ export class FigText extends Shape implements FigTextOptions, ShapeRenderable {
 
   render (): void {
     const cursor = this.cursor;
-    const text = this.text.split('\n');
+    const text = this.renderedText.split('\n');
     const x = parseInt(this.x);
     const y = parseInt(this.y);
     const background = this.background;