Skip to content

Commit

Permalink
Revert esbuild update
Browse files Browse the repository at this point in the history
  • Loading branch information
ggoodman committed Feb 27, 2021
1 parent 2b005e9 commit 6f5f3bf
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 12 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Revert chunk paths in nostalgie build while a bug in their resolution is investigated.

## [0.77.1] - 2021-02-27
### Changed
Expand Down
16 changes: 9 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"abort-controller": "^3.0.0",
"blob-polyfill": "^5.0.20210201",
"chokidar": "^3.5.1",
"esbuild": "^0.8.50",
"esbuild": "^0.8.52",
"escape-goat": "^3.0.0",
"escape-string-regexp": "^4.0.0",
"got": "^11.8.1",
Expand Down
4 changes: 2 additions & 2 deletions scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ async function buildPiscinaWorker(service) {
*/
async function buildRuntimeModules(service) {
await service.build({
assetNames: 'internal/[name]-[hash]',
// assetNames: '[name]-[hash]',
bundle: true,
chunkNames: 'internal/[name]-[hash]',
// chunkNames: '[name]-[hash]',
external: externalModules,
define: {
// 'process.env.NODE_ENV': JSON.stringify('production'),
Expand Down
4 changes: 2 additions & 2 deletions src/build/builders/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ export class ClientAssetBuilder {
'process.env.NOSTALGIE_PUBLIC_URL': '"/"',
},
logLevel: 'error',
assetNames: 'assets/[name]-[hash]',
chunkNames: 'chunks/[name]-[hash]',
// assetNames: 'assets/[name]-[hash]',
// chunkNames: 'chunks/[name]-[hash]',
external: [],
format: 'esm',
incremental: true,
Expand Down

0 comments on commit 6f5f3bf

Please sign in to comment.