Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for cran #418

Merged
merged 11 commits into from
Jun 19, 2021
Merged

Fix tests for cran #418

merged 11 commits into from
Jun 19, 2021

Conversation

schloerke
Copy link
Member

@schloerke schloerke commented Jun 19, 2021 •
edited
Loading

Fix #413

larmarange and others added 8 commits April 26, 2021 18:19
@schloerke schloerke mentioned this pull request Jun 19, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021 •
edited
Loading

Codecov Report

Merging #418 (ba31195) into master (bb51db8) will decrease coverage by 0.88%.
The diff coverage is 87.50%.

❗ Current head ba31195 differs from pull request most recent head 866980a. Consider uploading reports for the commit 866980a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   92.21%   91.32%   -0.89%     
==========================================
  Files          36       36              
  Lines        4354     4359       +5     
==========================================
- Hits         4015     3981      -34     
- Misses        339      378      +39
Impacted Files Coverage Δ
R/ggnetworkmap.R 85.89% <ø> (-0.65%) ⬇️
R/ggsurv.R 98.13% <ø> (ø)
R/ggcoef_model.R 97.20% <80.00%> (-0.67%) ⬇️
R/gg-plots.R 82.88% <100.00%> (ø)
R/ggcorr.R 99.33% <100.00%> (ø)
R/ggnet2.R 98.30% <100.00%> (-0.73%) ⬇️
R/ggparcoord.R 86.86% <0.00%> (-10.11%) ⬇️
R/ggnet.R 98.57% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b37d1e...866980a. Read the comment docs.

@schloerke
Copy link
Member Author

Merging early to move onto CRAN submission

@schloerke schloerke merged commit 01a2c67 into master Jun 19, 2021
@schloerke schloerke deleted the cran_fixes branch June 19, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ggcoef_plot() should be updated as guide = FALSE is now deprecated
3 participants
@schloerke @codecov-commenter @larmarange