bug fix in ggcoef_model when tidy() does not return a p.value (#400)

Co-authored-by: Joseph Larmarange <[email protected]>

R/ggcoef_model.R

@@ -495,6 +495,11 @@ ggcoef_data <- function (
     keep_model = FALSE
   )
 
+  if (!"p.value" %in% names(data)) {
+    data$p.value <- NA_real_
+    significance <- NULL
+  }
+
   if(!is.null(significance)) {
     if (is.null(significance_labels))
       significance_labels <- paste(c("p \u2264", "p >"), significance)

tests/testthat/test-ggcoef_model.R

@@ -92,12 +92,16 @@ test_that("example of ggcoef_model", {
 
   # or with different type of contrasts
   # for sum contrasts, the value of the reference term is computed
-  mod2 <- lm(
-    tip ~ day + time + sex,
-    data = tips,
-    contrasts = list(time = contr.sum, day = contr.treatment(4, base = 3))
-  )
-  expect_print(ggcoef_model(mod2))
+  emmeans_is_installed <- (system.file(package = "emmeans") != "")
+  if (emmeans_is_installed) {
+    mod2 <- lm(
+      tip ~ day + time + sex,
+      data = tips,
+      contrasts = list(time = contr.sum, day = contr.treatment(4, base = 3))
+    )
+    expect_print(ggcoef_model(mod2))
+
+  }
 
   # Use ggcoef_compare() for comparing several models on the same plot
   mod1 <- lm(Fertility ~ ., data = swiss)
@@ -124,3 +128,20 @@ test_that("example of ggcoef_model", {
 
 
 })
+
+test_that("ggcoef_model works with tieders not returning p-values", {
+  skip_if_not_installed("broom.helpers")
+  skip_if_not_installed("scagnostics")
+
+  mod <- lm(Sepal.Width ~ Species, iris)
+  my_tidier <- function(x, ...) {
+    x %>%
+      broom::tidy(...) %>%
+      dplyr::select(-.data$p.value)
+  }
+  expect_error(
+    mod %>% ggcoef_model(tidy_fun = my_tidier),
+    NA
+  )
+
+})