[SYCL] Add SYCL Backend registry, device and Event Interfaces #9705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
requested changes
Oct 1, 2024
There was a problem hiding this comment.
We cannot duplicate the async loading code in llama.cpp for each backend. In the next days I will make a PR that will make changes that will allow this code to work with any backend that implements the necessary ggml-backend interfaces (#9707).
github-actions
bot
added
ggml
|
Fair enough @slaren thanks for the hint. Will draft the current PR until then. |
|
@OuadiElfarouki #9707 got merged 🎉 |
OuadiElfarouki
changed the title
slaren
approved these changes
Oct 8, 2024
OuadiElfarouki
force-pushed
the
sycl_async_data_load
branch
from
08e843a to
b373dcd
Compare
Alcpz
approved these changes
Oct 9, 2024
drollings
pushed a commit
to drollings/llama.cpp
that referenced
this pull request
Oct 18, 2024
…rg#9705) * implemented missing SYCL event APIs * sycl : Added device and backend reg interfaces * Restructured ggml-sycl.cpp
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
…rg#9705) * implemented missing SYCL event APIs * sycl : Added device and backend reg interfaces * Restructured ggml-sycl.cpp
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
…rg#9705) * implemented missing SYCL event APIs * sycl : Added device and backend reg interfaces * Restructured ggml-sycl.cpp test passed
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
…rg#9705) * implemented missing SYCL event APIs * sycl : Added device and backend reg interfaces * Restructured ggml-sycl.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add Backend and Device registry as introduced in #9707 for SYCL Backend. This re-enables
test-backend-opsfor SYCL among others.This patch also implements most of the event APIs for the SYCL backend, fixes the
set_tensor_asyncand enables an async IO / H2D memory copies for model loading (similar to CUDA backend implementation).Some improvement figures (load time) :
Nvidia A100 40GB + LLaMa 3.1 70B Q4 : 27.6s (master) -> 5.8s (patch)
Intel Arc A770 + LLaMa 3.1 8B Q4 : 1.6s (master) -> 0.8s (patch)
I have read the contributing guidelines
Self-reported review complexity: