examples/gguf-split: Change binary multi-byte units to decimal #7803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while testing the Python convert-split PR #6942:
examples/gguf-split
at present uses binary multi-byte units (KiB, MiB, GiB).Decimal units (KB, MB, GB) would be better from a standardization perspective. HuggingFace recommends 5GB per file and imposes a hard limit of 50GB, both decimal, so a user using any splitting script will be more likely to be working in decimal units to comply with these limits.
However, tools like Linux
du
and Windows File Explorer use binary units, which could potentially lead to user confusion.This PR simply changes
examples/gguf-split
to use decimal units instead of binary units. SHA256 sums match with splits generated by the Python script #6942.