README: Update with CMake and windows example #748
Conversation
README.md
Outdated
| @@ -145,6 +145,9 @@ git clone https://github.com/ggerganov/llama.cpp | |||
| cd llama.cpp | |||
| make | |||
|
|
|||
| #For Windows and CMake, use the following command instead: | |||
| cmake -S . -B build/ -G "MinGW Makefiles" | |||
There was a problem hiding this comment.
this only works for mingw. but installing a vs community edition is much simpler for average users.
There was a problem hiding this comment.
Yes indeed, you could add the following lines for the people using vs and cmake:
cd <path_to_llama_folder>
mkdir build
cd build
cmake ..
cmake --build . --config Release
There was a problem hiding this comment.
Thanks, I have updated it with your suggestion
|
@ggerganov shall we consider to only use CMake to build the project? Maintaining makefile + cmake it hard. I already noticed some difference between two build system. When we need to pull in external dependency, it will be trickier to do so in Makefile. |
| @@ -145,6 +145,13 @@ git clone https://github.com/ggerganov/llama.cpp | |||
| cd llama.cpp | |||
| make | |||
|
|
|||
| #For Windows and CMake, use the following command instead: | |||
There was a problem hiding this comment.
the instruction looks good. can we also mentioned that the user needs to install visual studio?
|
@howard0su For now we will keep the Makefile since it is the most trivial way to build the project and a lot of developers appreciate the simplicity |
|
Hi, I tried to follow your updated guidelines to run the model. Unfortunately, I encounter the error "Error: could not load cache" when using command "cmake --build . --config Release". Any idea why please? I am using Windows 10, installed git, cmake, visual studio and anaconda, am using anaconda prompt. cmake .. gives this output : |
Added example to build the project using CMake since lot of people have been enquiring about this