Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe #700

Closed
wants to merge 8 commits into from
Closed

Update ReadMe #700

wants to merge 8 commits into from

Conversation

Shreyas-ITB
Copy link

Fixed some command issues, added model links and updated the Image

@@ -1,16 +1,15 @@
# llama.cpp

![llama](https://user-images.githubusercontent.com/1991296/227761327-6d83e30e-2200-41a6-bfbb-f575231c54f4.png)
![https://raw.githubusercontent.com/Shreyas-ITB/-/main/Friendly-Alpaca.png](https://raw.githubusercontent.com/Shreyas-ITB/---/main/Friendly-Alpaca.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL in square brackets gives a 404.

Has a change of the logo been discussed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That logo was very cool so i thought of changing it, if you guys dont like it then u can revert the logo change back.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the second link this one

@sw
Copy link
Contributor

sw commented Apr 2, 2023

I don't think I can approve this, you're essentially highjacking some of the links, and I think the consensus was not to have direct links to model downloads

@Shreyas-ITB
Copy link
Author

Well new members who are new to AI's and stuff doesn't know where to download the models. Even i had the problem. And im not hijacking the links tho. HuggingFace is opensource im just getting the links with the permission of the owner and pasting it there in the readme file. and its not even direct link to download the model, if you click on one of those links it just shows the files of the model that if you click on will download the file.

@prusnak
Copy link
Collaborator

prusnak commented Apr 2, 2023

And im not hijacking the links tho.

You changed the logo with no discussion.
You changed 3 links from https://github.com/ggerganov to https://github.com/Shreyas-ITB

👎

@Shreyas-ITB
Copy link
Author

Again guys if you dont want this pr just close it off. I dont mind it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants