Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precompiled files for windows x64 and python script instead of bash script. #197

Closed
wants to merge 1 commit into from

Conversation

Black-Engineer
Copy link

Precompiled files for windows x64 via Cmake.

@Black-Engineer Black-Engineer changed the title Add precompiled files for windiws x64 and python script instead of bash script. Add precompiled files for windows x64 and python script instead of bash script. Mar 16, 2023
@miolini
Copy link

miolini commented Mar 16, 2023

Please, do not distribute executable binaries in repository.

@LostRuins
Copy link
Collaborator

binaries should be in Releases, not repo.

@bernatvadell
Copy link
Contributor

Perhaps we could expose the artifacts generated in the CI pipeline.

And eventually make a version of the project to which the releases would be related to the binaries.

@miolini
Copy link

miolini commented Mar 16, 2023

It should be built only my core maintainers. Not by fresh github account with shady name.

@miolini
Copy link

miolini commented Mar 16, 2023

Screenshot 2023-03-16 at 9 43 57 AM

@leumasme
Copy link

leumasme commented Mar 16, 2023

Why doesn't the Github Actions workflow build file publish the build result files as github artifacts? That'd allow downloading the build result of every action run.

@HCBlackFox
Copy link

Not by fresh github account with shady name.

Lol, why you are so rude? Yes Im new here, but that is not concern to blame me...I simply dont know how to do it right. You can tell me in normal words without agresion.

@Hades32
Copy link

Hades32 commented Mar 16, 2023

Haven't had time to put do this right (i.e. make a PR and have the workflow create a release with multiple artifacts), but if someone just wants the Windows binaries, here I have them being built with GH actions with a minimal fork: https://github.com/Hades32/llama.cpp/actions/runs/4441656002

@LostRuins
Copy link
Collaborator

In any case, this project has basically zero dependencies. Just clone this repo and type make and you'll have your binaries in under 10 seconds.

@gjmulder gjmulder added enhancement New feature or request invalid This doesn't seem right labels Mar 17, 2023
@prusnak
Copy link
Collaborator

prusnak commented Mar 18, 2023

Closing since we don't want to have unreproducible executables committed in the git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants