Run provisioner cleanup when destroying VMs #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vagrant v1.3.0 introduced the ability for provisioners to define cleanup tasks that get run during VM destruction in order to clean up bits of global state. This patch adds the ProvisionerCleanup task to the OpenStack destroy action.
|
@Sharpie I suppose you use the Chef client provisionner ? Up to now it seems to be the only one that implement this feature. Unfortunately i don't have an up and running Chef server to test it on my side. Can you confirm you successfully tested it with the Chef client provisionner ? |
|
I use a Puppet provisioner which de-registers a machine that is being destroyed, along with a hostname provisioner that manages I also use multiple providers on a regular basis: VirtualBox, AWS, OpenStack, vSphere. So, having consistent provisioner cleanup behavior between all is important as well. |
Sharpie
pushed a commit
to Sharpie/vagrant-openstack-provider
that referenced
this pull request
Jul 25, 2016
…anup Run provisioner cleanup when destroying VMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vagrant v1.3.0 introduced the ability for provisioners to define cleanup tasks
that get run during VM destruction in order to clean up bits of global state.
This patch adds the ProvisionerCleanup task to the OpenStack destroy action.