Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade json gem version to latest #268

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Upgrade json gem version to latest #268

merged 1 commit into from
Feb 19, 2016

Conversation

dandunckelman
Copy link
Contributor

After further discussion in #267, I've recreated the PR since I deleted the original fork, derp. The only difference between that PR and this one is that I updated to Ruby v2.2.3, whereas the other PR used v2.2.2.

I wanted to install this plugin with the latest Vagrant (v.1.8.1 when I went to https://www.vagrantup.com/downloads.html) but received errors when bundle tries installing the json gem v1.7.7. So, I figured I'd try getting the install to work with the latest JSON gem.

To do this, I performed the following on an Ubuntu v14.04 VM with Ruby v2.2.3 (via RVM):

  • Fork repo

  • Clone repo to my box

    git clone https://github.com/dandunckelman/vagrant-openstack-provider.git
    
  • Create topic branch

    cd vagrant-openstack-provider
    git checkout -b upgrade-json-dependency
    
  • Setup Ruby environment (since I use RVM):

    cd source/
    echo "2.2.3" > .ruby-version
    echo "vagrant-openstack-provider" > .ruby-gemset
    
  • Install specific bundler version (since the Vagrant v1.7.4 gem requires bundler (<= 1.10.5, >= 1.5.2))

    gem install bundler -v 1.10.5
    
  • Install gems

    bundle
    
  • Run tests

    bundle exec rake
    
  • Build as a gem

    bundle exec rake build
    
  • Install plugin from gem

    cd ../../my-vagrant-project/
    vagrant plugin install ../vagrant-openstack-provider/source/pkg/vagrant-openstack-provider-0.7.0.gem
    

Then the install worked as expected. I assume that this would fix the following issues: #265 &
#266

Should I update .travis.yml to do the following or something similar?

  • Add 2.2.3 to the rvm list
  • Add VAGRANT_VERSION=v1.8.1 BUNDLER_VERSION=1.10.5 to the matrix list

@beddari
Copy link

beddari commented Jan 20, 2016

Verified as working on Fedora 23 using the latest vagrantup.com vagrant package and system Ruby to build the updated .gem:

git clone https://github.com/dandunckelman/vagrant-openstack-provider.git
cd vagrant-openstack-provider/source
git checkout upgrade-json-dependency
sudo dnf install ruby-devel redhat-rpm-config
bundle
bundle exec rake build
vagrant plugin install pkg/vagrant-openstack-provider-0.7.0.gem

@artem-sidorenko
Copy link
Contributor

Verified on Ubuntu 14.04 with latest vagrant, works

@jhoblitt
Copy link

jhoblitt commented Feb 5, 2016

Confirmed as working with the vagrant-1.8.1-1.x86_64 rpm (vagrantup; not fedora's native packaging) on Fedora 23.

@jhoblitt jhoblitt mentioned this pull request Feb 5, 2016
@wbean1
Copy link

wbean1 commented Feb 8, 2016

+1, encountered same issue trying to use this plugin on Vagrant 1.8.1... thanks for providing the manual plugin build work-around... hope this gets merged.

@ggiamarchi
Copy link
Owner

LGTM

Sorry guys for the long time to merge the one.

ggiamarchi added a commit that referenced this pull request Feb 19, 2016
@ggiamarchi ggiamarchi merged commit 68452ac into ggiamarchi:master Feb 19, 2016
@ggiamarchi ggiamarchi added this to the 0.7.1 milestone Feb 19, 2016
@ggiamarchi
Copy link
Owner

Included in release 0.7.1

@dandunckelman
Copy link
Contributor Author

@ggiamarchi thanks!

@v1k0d3n
Copy link
Contributor

v1k0d3n commented Feb 19, 2016

@ggiamarchi Thank you for resolving this issue!!

@jhoblitt
Copy link

@ggiamarchi Thank you! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants