-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade json gem version to latest #268
Upgrade json gem version to latest #268
Conversation
Verified as working on Fedora 23 using the latest vagrantup.com vagrant package and system Ruby to build the updated .gem:
|
Verified on Ubuntu 14.04 with latest vagrant, works |
Confirmed as working with the vagrant-1.8.1-1.x86_64 rpm (vagrantup; not fedora's native packaging) on Fedora 23. |
+1, encountered same issue trying to use this plugin on Vagrant 1.8.1... thanks for providing the manual plugin build work-around... hope this gets merged. |
LGTM Sorry guys for the long time to merge the one. |
Upgrade json gem version to latest
Included in release 0.7.1 |
@ggiamarchi thanks! |
@ggiamarchi Thank you for resolving this issue!! |
@ggiamarchi Thank you! 👏 |
After further discussion in #267, I've recreated the PR since I deleted the original fork, derp. The only difference between that PR and this one is that I updated to Ruby v2.2.3, whereas the other PR used v2.2.2.
I wanted to install this plugin with the latest Vagrant (v.1.8.1 when I went to https://www.vagrantup.com/downloads.html) but received errors when bundle tries installing the json gem v1.7.7. So, I figured I'd try getting the install to work with the latest JSON gem.
To do this, I performed the following on an Ubuntu v14.04 VM with Ruby v2.2.3 (via RVM):
Fork repo
Clone repo to my box
Create topic branch
Setup Ruby environment (since I use RVM):
Install specific bundler version (since the Vagrant v1.7.4 gem requires bundler (<= 1.10.5, >= 1.5.2))
Install gems
Run tests
Build as a gem
Install plugin from gem
Then the install worked as expected. I assume that this would fix the following issues: #265 &
#266
Should I update .travis.yml to do the following or something similar?