-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support Windows (build Visual Studio 2022) #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CHERTS - thank you very much for the contribution!
I want to keep the third-party dependencies at minimum, so before merging this the SDL
, pthreads4w
and stdatomic
dependencies have to be removed.
- The
SDL
library is only needed for thestream
example and the user should provide it themselves if they want to use it - On Windows, there is a native thread API that should be used instead of
pthreads
- The
stdatomic
is part of the C11 standard so it should be directly supported by the compiler - not sure why you had to add third-party implementation
|
I'm sorry, but I don't see the point in removing the SDL header files from the VisualStudio project, without them it won't be able to compile |
Fix panic in stereo to mono audio conversion
Hi,
I've added support Windows (build in Visual Studio 2022), everything builds and works just fine.