Add assertion informing the API user about missing llama_encode() call #8400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jul 10, 2024
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 11, 2024
Co-authored-by: Stanisław Szymczyk <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 13, 2024
Co-authored-by: Stanisław Szymczyk <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 13, 2024
Co-authored-by: Stanisław Szymczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using encoder-decoder models like T5 without calling
llama_encode()first currently results in a cryptic error message:GGML_ASSERT: ggml/src/ggml.c:5278: !ggml_is_transposed(a)that is already causing confusion: #8398.
This PR adds an assertion to
build_t5()that informs the API user about the necessity of callingllama_encode()first if there are no encoder outputs present duringllama_decode(). With this PR the error message is:GGML_ASSERT: src/llama.cpp:13203: n_outputs_enc > 0 && "call llama_encode() first"