Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: move PR template to .github/ root #7868

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mofosyne
Copy link
Collaborator

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

To store your file in a hidden directory, name the pull request template .github/pull_request_template.md.

Turns out we need to move it to there for it to be used as generic template

PULL_REQUEST_TEMPLATE subdirectory is for templated urls e.g. https://github.com/octo-org/octo-repo/compare/main...my-branch?quick_pull=1&template=issue_template.md . I'm unsure if we need that feature yet so just deleting that folder for now.

@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix devops improvements to build systems and github actions labels Jun 11, 2024
@mofosyne mofosyne requested a review from ggerganov June 11, 2024 13:52
@ggerganov ggerganov merged commit 6fe42d0 into ggerganov:master Jun 11, 2024
1 check passed
@mofosyne mofosyne deleted the move-pr-template branch June 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants