Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker.yml: disable light-intel and server-intel test #7515

Merged
merged 2 commits into from
May 24, 2024
Merged

docker.yml: disable light-intel and server-intel test #7515

merged 2 commits into from
May 24, 2024

Conversation

mofosyne
Copy link
Collaborator

@mofosyne mofosyne commented May 24, 2024 •
edited
Loading

Disable test

#7507

@github-actions github-actions bot added the devops improvements to build systems and github actions label May 24, 2024
@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label May 24, 2024
@mofosyne
Copy link
Collaborator Author

mofosyne commented May 24, 2024 •
edited
Loading

Let's give it a day or two to see if someone finds a solution before disabling the CI

To be merged around 26th May of Sunday if no solution found yet (or merged sooner if this CI issue is getting in the way of higher priority PR by making it harder to see passing CI statuses)

@mofosyne mofosyne added the merge ready indicates that this may be ready to merge soon and is just holding out in case of objections label May 24, 2024
@mofosyne mofosyne changed the title docker.yml: disable light-intel test docker.yml: disable light-intel and server-intel test May 24, 2024
@mofosyne mofosyne mentioned this pull request May 24, 2024
Closed
@mofosyne mofosyne requested a review from ngxson May 24, 2024 13:30
ngxson
ngxson approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe when Intel fix the base image, we can enable this back. For now, not much we can do.

@mofosyne
Copy link
Collaborator Author

Ah you are right. According to Xavier_V in intel community forum, he was also experiencing a similar issue on 05-21-2024, which is a few days ago. So this doesn't appear to be an isolated incident.

Given this appears to be an upstream incident. Let's disable this for now and check in a week or so when intel fixes their public key.

Source: https://community.intel.com/t5/Intel-oneAPI-Math-Kernel-Library/APT-Repository-not-working-signatures-invalid/m-p/1599436

@mofosyne mofosyne merged commit 27891f6 into ggerganov:master May 24, 2024
17 checks passed
@mofosyne mofosyne deleted the 7507-disable-test branch May 24, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson approved these changes

Assignees
No one assigned
Labels
devops improvements to build systems and github actions merge ready indicates that this may be ready to merge soon and is just holding out in case of objections Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofosyne @ngxson