Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc : register backend devices #11262

Merged
merged 1 commit into from
Jan 17, 2025
Merged

rpc : register backend devices #11262

merged 1 commit into from
Jan 17, 2025

Conversation

rgerganov
Copy link
Collaborator

Early register RPC devices and do not propagate RPC specifics in the llama model structures.

ref: #10609

@github-actions github-actions bot added examples ggml changes relating to the ggml tensor library for machine learning labels Jan 16, 2025
@rgerganov
Copy link
Collaborator Author

@slaren this is an attempt to address #10609 by making ggml_backend_device_register() public API. Let me know what you think.

ngxson
ngxson reviewed Jan 16, 2025
View reviewed changes
common/arg.cpp Outdated Show resolved Hide resolved
slaren
slaren approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please remember to update the API changelog in #9289

@slaren slaren linked an issue Jan 16, 2025 that may be closed by this pull request
Feature Request: Support RPC with -dev/-devd #10609
Closed
4 tasks
@rgerganov
rpc : early register backend devices
b38e86f 
Early register RPC devices and do not propagate RPC specifics in the
llama model structures.

ref: ggerganov#10609
@rgerganov rgerganov mentioned this pull request Jan 17, 2025
Closed
4 tasks
@rgerganov rgerganov merged commit 667d728 into ggerganov:master Jan 17, 2025
48 checks passed
@rgerganov rgerganov mentioned this pull request Jan 12, 2025
Open
@thxCode thxCode mentioned this pull request Jan 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson ngxson left review comments

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
examples ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support RPC with -dev/-devd
3 participants
@rgerganov @slaren @ngxson