-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GLM-Edge and GLM-Edge-V series models #10573
Conversation
…port_glm_edge_model
…port_glm_edge_model
Is there anyone available to review the code? |
@piDack As this would be adding support for GlmForCausalLM for these vision models, I'm curious to know if we could create a more modular or generic implementation that could also be used for the other GlmForCausalLM model(s)? I'm asking because glm-4-9b-chat-hf is currently broken with the new transformers-only implementation:
The version with the custom python files still works but if we're moving away from that (related discussion), it might be best to support GlmForCausalLM in general. Are there any parts of this PR that could be refactored or generalized for broader applicability so that we can support both and maybe upcoming models? Thank you. |
I will tried to do it |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many places still having inconsistent style
@ggerganov Could you have a look quickly on |
I believe it's ready to be merged into the master branch. |
This pull request support for the GLM-Edge-Chat 1.5B & 4B and GLM-Edge-V 2B & 5B series of models within the llama.cpp.
Note: The current model pretrain -> gguf only supports using the transformers version 4.47.0.dev0.