Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Expose texture format feature query (and update to latest wgpu) #713

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 12, 2021

Exposes texture format feature query from gfx-rs/wgpu#1112
Updating wgpu-core led to breaking change of moving get_swap_chain_preferred_format from device to adapter.

Copy link

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 2 warnings, 6 errors.

The .monocodus config not found in your repo. Default config is used.
Check config documentation here

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
Let's make the CI happy

@Wumpf Wumpf force-pushed the texture-format-feature-query branch from 41741b2 to 5ad4f19 Compare January 13, 2021 22:26
@Wumpf
Copy link
Member Author

Wumpf commented Jan 13, 2021

Aw, Ci failed because someone else meanwhile landed wgpu update on master. Dropped that commit, should be alright now

@kvark
Copy link
Member

kvark commented Jan 13, 2021 via email

@bors
Copy link
Contributor

bors bot commented Jan 14, 2021

@bors bors bot merged commit baf6c43 into gfx-rs:master Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants