Additional operands support (from BitEnum and ValueEnum) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Bekkers
changed the title
khyperia
approved these changes
Feb 11, 2021
|
It's unfortunate that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in PR #183 we added required_capabilities and required_extension to spirv_headers. This PR moves those into
dr::Operandand addsadditional_operands.additional_operandsis needed because some enum operands to instructions can specify additional operands that need parsing. Case in point would be anOpDecoratewhich only has one operand by default and the remaining operands are specified through that. So to properly parseOpDecorate DescriptorSet 0one needs to have called thisadditional_operandsfunction to know what follows afterDescriptorSet.