Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gl] Add Instance struct in web version to align API with other backends. #3506

Merged
merged 2 commits into from
Dec 3, 2020
Merged

[gl] Add Instance struct in web version to align API with other backends. #3506

merged 2 commits into from
Dec 3, 2020

Conversation

VincentJousse
Copy link

PR checklist:

  • make succeeds (on macOS)
  • make reftests succeeds
  • tested examples with the following backends: quad example with gl backend with wasm target arch (no windows nor linux available to test gl backend there)

@VincentJousse
Copy link
Author

VincentJousse commented Dec 3, 2020 •
edited
Loading

I did not prevent create_surface() from creating one more surface when one already exists since no Error seems to be relevant.

kvark
kvark reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It's the last piece of the puzzle to get the API aligned between all the backends. Just a few notes before we go.

Use parking_lot::Mutex.
6fd2d81 
Implement destroy_surface function.
kvark
kvark approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you!
bors r+

@VincentJousse
Copy link
Author

My pleasure !

@bors
Copy link
Contributor

bors bot commented Dec 3, 2020

Build succeeded:

@bors bors bot merged commit c05787b into gfx-rs:master Dec 3, 2020
@kvark kvark mentioned this pull request Dec 3, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

@monocodus monocodus[bot] monocodus[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentJousse @kvark