Add few unsafe markers #2526
Merged
Add few unsafe markers #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Dec 24, 2018
| @@ -3,6 +3,7 @@ name = "hal-examples" | |||
| version = "0.1.0" | |||
| publish = false | |||
| workspace = ".." | |||
| edition = "2018" | |||
There was a problem hiding this comment.
let's leave the edition update to other PRs, the scope is already high, unless you require it for this to work
There was a problem hiding this comment.
The code needs nll. Because I've messed with blocks.
It set only for examples though. And there were no changes to compile for 2018
|
Can you remove the second commit please? |
|
Nightly is broken. It happens sometimes. I don't think it should disturb our workflow. Especially when we want to roll our first release. |
|
The issue rust-lang/rust#57111 is resolved now, please remove the last commit. |
|
If you insist |
|
Thank you!
Bors r+
… On Dec 26, 2018, at 02:42, Zakarum ***@***.***> wrote:
If you insist
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
bors bot
added a commit
that referenced
this pull request
Dec 26, 2018
2526: Add few unsafe markers r=kvark a=omni-viral Fixes #2453 PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: metal - [ ] `rustfmt` run on changed code Co-authored-by: Zakarum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2453
PR checklist:
makesucceeds (on *nix)make reftestssucceedsmetal
rustfmtrun on changed code