Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx12: Update to latest wio version #1765

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Conversation

msiglreith
Copy link
Contributor

@msiglreith msiglreith commented Jan 26, 2018

Should only be merged once a new crates.io version has been published.

Fixes https://github.com/gfx-rs/gfx/issues/1754

@kvark
Copy link
Member

kvark commented Jan 27, 2018

Doesn't look to be failing :)

@msiglreith
Copy link
Contributor Author

Restructured code a bit to work around that ComPtr assert, just waiting on publish right now.
cc @retep998

@kvark
Copy link
Member

kvark commented Jan 30, 2018

Let's do it! https://crates.io/crates/wio/0.2.0

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it
bors r+

bors bot added a commit that referenced this pull request Jan 30, 2018
1765: dx12: Update to latest wio version r=kvark a=msiglreith

~~~Currently fails due to new nullptr assert.~~~
Should only be merged once a new crates.io version has been published.

Fixes #1754
@bors
Copy link
Contributor

bors bot commented Jan 30, 2018

@bors bors bot merged commit 6ceb7b1 into gfx-rs:master Jan 30, 2018
@Skepfyr Skepfyr mentioned this pull request Apr 16, 2018
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants