Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal vertex buffer stride #2077

Open
kvark opened this issue May 28, 2018 · 1 comment
Open

Metal vertex buffer stride #2077

kvark opened this issue May 28, 2018 · 1 comment
Labels
backend: Metal client: CTS Has associated Vulkan CTS tests that fail or crash module: hal type: discussion

Comments

@kvark
Copy link
Member

kvark commented May 28, 2018

Metal requires the buffer strides to be multiple of 4, while Vulkan does not. There are quite a few failing tests inside "dEQP-VK.memory.*" that depend on that.

@kvark kvark added this to the Vulkan Portability MVP milestone May 28, 2018
bors bot added a commit that referenced this issue May 29, 2018
2076: Metal revised memory types r=grovesNL a=kvark

Fixes #2069
~~Includes #2070 (please only review the last 2 commits)~~

The PR effectively removes all the complicated memory allocation tracking from the Metal backend, instead relying on mapping the available storage types (with CPU caching policy) more accurately to what can be represented in Vulkan API.

With this in, we slice through the whole `memory` section without crashes. The only issue I failed to fix/workaround is filed as #2077

PR checklist:
- [x] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends: metal


Co-authored-by: Dzmitry Malyshau <[email protected]>
@kvark kvark removed the api: hal label Jun 26, 2019
@kvark
Copy link
Member Author

kvark commented Oct 1, 2019

I don't think this is actionable - we'll encode this limitation in the portability spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Metal client: CTS Has associated Vulkan CTS tests that fail or crash module: hal type: discussion
Projects
None yet
Development

No branches or pull requests

1 participant