Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unsound errors #1143

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fixed unsound errors #1143

merged 1 commit into from
Aug 20, 2020

Conversation

Lucretiel
Copy link
Contributor

Currently, the zola error type has:

unsafe impl Sync for Error {}
unsafe impl Send for Error {}

These impls are unsound, because Box<dyn Error> may be a !Send or !Sync type, and because Syntect errors are !Sync. This pull request updates to Syntect 4.4, which fixes this, and updates source to be dyn Error + Send + Sync. This removes the unsoundness, and the need for any unsafe in error.

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

@Keats Keats merged commit af0dd5e into getzola:next Aug 20, 2020
@Keats
Copy link
Collaborator

Keats commented Aug 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants