Enable usage of vault's TokenHelpers #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a useful feature |
|
I am still using a personal fork of SOPS in order to have this feature. However if there is interest and this could be merged upstream I can devote some time to refresh the PR against latest. |
|
@pruiz I'm using a custom build of sops with your patch applied too and would definitely be interested in this being added upstream :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for vault's token helpers (https://www.vaultproject.io/docs/commands/token-helper), as exposed by vault api. This allows working against multiple vault instances, obtaining a valid token depending on the address of the vault client being requested.