Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INI, DotEnv stores: shamir_threshold is an integer #1394

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

felixfontein
Copy link
Contributor

Fixes #857 similarly to #1338.

Signed-off-by: Felix Fontein <[email protected]>
Copy link
Contributor

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM

@felixfontein felixfontein merged commit 06db542 into getsops:main Dec 29, 2023
@felixfontein felixfontein deleted the metadata-types branch December 29, 2023 21:11
@felixfontein
Copy link
Contributor Author

@devstein thanks for reviewing! Using mapstructure is probably a better solution (as in #1009 and #1338), but the main commits in there are missing the DCO signoff, so I'm not sure how we can continue with these PRs...

@devstein
Copy link
Contributor

Oh nice. I pinged the authors about fixing. Worst case we can re-create another PR ourselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shamir treshold breaks env files (panic: interface conversion: interface {} is float64, not string)
2 participants