Fix: Trace Root transaction name #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent in tracedetailheader as well
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
+ Coverage 31.28% 31.32% +0.04%
==========================================
Files 91 92 +1
Lines 5396 5421 +25
Branches 99 99
==========================================
+ Hits 1688 1698 +10
- Misses 3708 3723 +15 ☔ View full report in Codecov by Sentry. |
BYK
approved these changes
Dec 5, 2024
| @@ -9,7 +10,10 @@ export default function TraceDetailHeader({ trace }: TraceDetailHeaderProps) { | |||
| return ( | |||
| <div className="border-b-primary-700 bg-primary-950 flex items-center gap-x-2 border-b px-6 py-4"> | |||
| <TraceIcon trace={trace} /> | |||
| <h1 className="max-w-full flex-1 truncate text-2xl">{trace.rootTransactionName}</h1> | |||
| <h1 className="flex w-full flex-1 items-center truncate text-2xl"> | |||
| Trace: | |||
There was a problem hiding this comment.
Do we really need the two spaces here? 😅
There was a problem hiding this comment.
Yeah just to give some space between tag and "Trace:"
BYK
pushed a commit
that referenced
this pull request
Dec 11, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or [setup this action to publish automatically](https://github.com/changesets/action#with-publishing). If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @spotlightjs/[email protected] ### Minor Changes - Add Sentry SDK for monitoring ([#620](#620)) ### Patch Changes - Fix Spotlight UI not using correct sidecar URL w/ non-default port ([#618](#618)) - Don't alter body styles at all ([#615](#615)) - Make in-browser direct Sentry SDK link more graceful at the start ([#614](#614)) - Updated dependencies \[[`7ea060b832a67cf39676d7fbdbbecb02bb2830e3`](7ea060b), [`705595349718abb1dea188efc92ab02a4268f323`](7055953), [`76bc48618812f260b8788b83926fa36fbd9ade35`](76bc486), [`4716ddeda0e52289b0f9bc9889ffcf957a69d1a8`](4716dde), [`a77a8698bd892762b149b555058eb345fac2c686`](a77a869), [`6240009c99fa4699f25325e356b32dc8849e3b92`](6240009)]: - @spotlightjs/[email protected] - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`455f6966d0602af38fd0835627d11dea03b88362`](455f696), [`4716ddeda0e52289b0f9bc9889ffcf957a69d1a8`](4716dde), [`6240009c99fa4699f25325e356b32dc8849e3b92`](6240009), [`f0bb9a98b4df7ce49c9fd73a093dc7b2005305b9`](f0bb9a9)]: - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Updated dependencies \[[`7ea060b832a67cf39676d7fbdbbecb02bb2830e3`](7ea060b), [`705595349718abb1dea188efc92ab02a4268f323`](7055953), [`76bc48618812f260b8788b83926fa36fbd9ade35`](76bc486), [`4716ddeda0e52289b0f9bc9889ffcf957a69d1a8`](4716dde), [`a77a8698bd892762b149b555058eb345fac2c686`](a77a869), [`6240009c99fa4699f25325e356b32dc8849e3b92`](6240009)]: - @spotlightjs/[email protected] - @spotlightjs/[email protected] ## @spotlightjs/[email protected] ### Patch Changes - Use a maintained version of ReactJsonViewer ([#611](#611)) - - Added a createTab helper function ([#606](#606)) - Added Trace root transaction name in Trace detail header ([#612](#612)) - Don't alter body styles at all ([#615](#615)) - Make in-browser direct Sentry SDK link more graceful at the start ([#614](#614)) ## @spotlightjs/[email protected] ### Patch Changes - Fix sidecar package build, export all from dist with types ([#616](#616)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before opening this PR:
pnpm changeset:add#607
