Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sentry attribution in docs and overlay trigger minor bug fixed #542

Merged
merged 3 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-olives-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@spotlightjs/overlay': patch
---

Fixed minor overlay trigger count issue
4 changes: 2 additions & 2 deletions packages/overlay/src/components/Trigger.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function ToolbarItem({
<div className="gap-x hover:bg-primary-400 relative flex items-center rounded p-3" {...props}>
{children}

{count && (
{count ? (
<span
className={classNames(
severe ? 'bg-red-500' : 'bg-primary-500',
Expand All @@ -44,7 +44,7 @@ function ToolbarItem({
>
{count}
</span>
)}
) : null}
</div>
);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/website/src/components/Footer.astro
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</style>

<div class="footer">
<span>Created by <a href="https://sentry.io">Sentry</a></span>
<span>Brought to you by <a href="https://sentry.io">Sentry</a></span>
<span>Check it out on <a href="https://github.com/getsentry/spotlight">GitHub</a></span>
<span>Visit us on <a href="https://discord.com/channels/621778831602221064/1176977569678114847">Discord</a></span>
</div>
13 changes: 12 additions & 1 deletion packages/website/src/components/Header.astro
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,19 @@ const showSearch = Astro.props.slug !== '';
---

<div class="header sl-flex">
<div class="sl-flex">
<div class="sl-flex items-center gap-x-1">
<SiteTitle {...Astro.props} />
<div class="flex items-center gap-x-1 text-sm leading-5">
<span>by</span>
<a
rel="noopener"
href="https://sentry.io"
target="_blank"
class="no-underline text-inherit focus:outline-none font-medium hover:underline"
>
Sentry
</a>
</div>
</div>
<div class="sl-flex">
{showSearch && <Search {...Astro.props} />}
Expand Down
Loading