Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Spotlight just for Frontend #133

Closed
HazAT opened this issue Nov 24, 2023 · 3 comments
Closed

Feature: Spotlight just for Frontend #133

HazAT opened this issue Nov 24, 2023 · 3 comments
Assignees
@BYK
Labels
Type: Enhancement New feature or request
Milestone
3.0

Comments

@HazAT
Copy link
Member

HazAT commented Nov 24, 2023

Make Spotlight a mode that, if it fails to connect to the sidecar from the frontend and can try to directly send stuff from the Sentry Browser SDK to the Overlay.
For pure frontends, this would make it possible to run it without the sidecar.
@HazAT HazAT mentioned this issue Nov 24, 2023
Open
@lforst
Copy link
Member

lforst commented Nov 24, 2023

A really cool architecture here would be to have a webworker that intercepts all the requests from the browser and acts as a sidecar, until it detects an actual sidecar and then forwards/proxies everything.

@Lms24
Copy link
Member

Lms24 commented Nov 24, 2023

Spotlight overlay already has an event target we can use to communicate. Maybe we send events via the target to the sentry datacache.

@HazAT HazAT added this to the 2.0 milestone Nov 24, 2023
@Shubhdeep12 Shubhdeep12 added the Type: Enhancement New feature or request label Feb 3, 2024
@Lms24 Lms24 modified the milestones: 2.0, 3.0 Jun 13, 2024
@BYK BYK self-assigned this Aug 6, 2024
@BYK BYK mentioned this issue Aug 20, 2024
Closed
@mydea mydea mentioned this issue Aug 21, 2024
Open
BYK added a commit that referenced this issue Aug 26, 2024
@BYK
ref: Refactor sidecar connection code for other sources
1bcf490 
This is the first step to send events into Spotlight UI through other means than the sidecar connection.

Related to #133 and #498.
@BYK BYK mentioned this issue Aug 26, 2024
Merged
BYK added a commit that referenced this issue Aug 27, 2024
@BYK
ref: Refactor sidecar connection code for other sources (#506)
b2b5c85 
This is the first step to send events into Spotlight UI through other
means than the sidecar connection.

Related to #133 and #498.
BYK added a commit that referenced this issue Aug 27, 2024
@BYK
feat(overlay): Add direct event sending w/o sidecar
de0f845 
Working towards #133, supersedes #498
@BYK BYK mentioned this issue Aug 27, 2024
Merged
BYK added a commit that referenced this issue Aug 27, 2024
@BYK
feat(overlay): Add direct event sending w/o sidecar (#508)
5013585 
Working towards #133, supersedes #498
@BYK BYK mentioned this issue Aug 27, 2024
Merged
BYK added a commit that referenced this issue Aug 28, 2024
@BYK
feat: Add no-sidecar Sentry SDK integration for overlay (#509)
4acbad0 
Ref #133.
@BYK
Copy link
Member

BYK commented Sep 13, 2024

Closing this out as this is now a reality. The drop-in IIFE CDN bundle works especially well in this scenario.

@BYK BYK closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BYK BYK

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
5 participants
@BYK @HazAT @lforst @Lms24 @Shubhdeep12