fix: Fix electron version names in Sentry (#633)

Currently, we see git SHAs as version names in Sentry for the Electron project. This fix should give us semver versions instead.
getsentry · Dec 14, 2024 · 9251c8c · 9251c8c
1 parent 09d3179
commit 9251c8c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/packages/electron/electron.vite.config.js b/packages/electron/electron.vite.config.js
@@ -13,14 +13,18 @@ export default defineConfig(({ mode }) => {
     env = loadEnv(mode);
   }
   return {
+    define: {
+      'process.env.NODE_ENV': '"production"',
+      'process.env.npm_package_version': JSON.stringify(process.env.npm_package_version),
+    },
     main: {
       plugins: [
         sentryVitePlugin({
           org: env.MAIN_VITE_SENTRY_ORG,
           project: env.MAIN_VITE_SENTRY_PROJECT,
           authToken: env.MAIN_VITE_SENTRY_AUTH_TOKEN,
           release: {
-            name: `spotlight@${process.env.npm_package_version}`,
+            name: process.env.npm_package_version,
           },
         }),
       ],
@@ -41,7 +45,7 @@ export default defineConfig(({ mode }) => {
           project: env.MAIN_VITE_SENTRY_PROJECT,
           authToken: env.MAIN_VITE_SENTRY_AUTH_TOKEN,
           release: {
-            name: `spotlight@${process.env.npm_package_version}`,
+            name: process.env.npm_package_version,
           },
         }),
       ],

diff --git a/packages/electron/src/electron/main/index.ts b/packages/electron/src/electron/main/index.ts
@@ -9,7 +9,8 @@ const store = new Store();
 Sentry.init({
   dsn: 'https://[email protected]/4506400311934976',
   tracesSampleRate: 1.0,
-  release: `spotlight@${process.env.npm_package_version}`,
+  environment: process.env.NODE_ENV,
+  release: process.env.npm_package_version,
   beforeSend: askForPermissionToSendToSentry,
 });
 

diff --git a/packages/electron/src/index.ts b/packages/electron/src/index.ts
@@ -3,6 +3,8 @@ import * as Spotlight from '@spotlightjs/overlay';
 
 Sentry.init({
   dsn: 'https://[email protected]/4506400311934976',
+  environment: process.env.NODE_ENV,
+  release: process.env.npm_package_version,
   integrations: [
     Sentry.browserTracingIntegration(),
     Sentry.replayIntegration({

diff --git a/packages/spotlight/vite.overlay.config.ts b/packages/spotlight/vite.overlay.config.ts
@@ -3,7 +3,7 @@ import { defineConfig } from 'vite';
 
 export default defineConfig({
   define: {
-    'process.env.NODE_ENV': "'production'",
+    'process.env.NODE_ENV': '"production"',
     'process.env.npm_package_version': JSON.stringify(process.env.npm_package_version),
   },
   build: {