fix: Fix logical mistakes in integration event processing (#470)

We had multiple logical mistakes, such as not matching on lower-cased content type headers or skipping the entire event handler when a single integration did not define an event processor. This PR fixes these logical issues.
getsentry · Aug 1, 2024 · 0f10d81 · 0f10d81
1 parent 3b4d3fe
commit 0f10d81
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/.changeset/lovely-chefs-attend.md b/.changeset/lovely-chefs-attend.md
@@ -0,0 +1,5 @@
+---
+'@spotlightjs/overlay': patch
+---
+
+Fix event processing pipeline for integrations
diff --git a/packages/overlay/src/sidecar.ts b/packages/overlay/src/sidecar.ts
@@ -17,22 +17,23 @@ export function connectToSidecar(
     const listener = (event: MessageEvent): void => {
       log(`Received new ${contentType} event`);
       for (const integration of integrations) {
-        if (!integration.processEvent) {
-          return;
+        const integrationData = integration.processEvent
+          ? integration.processEvent({
+              contentType,
+              data: event.data,
+            })
+          : { event };
+
+        if (!integrationData) {
+          continue;
         }
-        const processedEvent = integration.processEvent({
-          contentType,
-          data: event.data,
+        setIntegrationData(prev => {
+          const integrationName = integration.name;
+          return {
+            ...prev,
+            [integrationName]: [...(prev[integrationName] || []), integrationData],
+          };
         });
-        if (processedEvent) {
-          setIntegrationData(prev => {
-            const integrationName = integration.name;
-            return {
-              ...prev,
-              [integrationName]: [...(prev[integrationName] || []), processedEvent],
-            };
-          });
-        }
       }
     };