fix(hackweek): Use the correct event Typed Dict in event processor base. #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Aug 5, 2020
snuba/datasets/errors_processor.py
Outdated
| @@ -46,8 +46,7 @@ def extract_custom( | |||
| metadata: KafkaMessageMetadata, | |||
| ) -> None: | |||
| data = event.get("data", {}) | |||
| user_dict = data.get("user", data.get("sentry.interfaces.User", None)) or {} | |||
|
|
|||
| user_dict = data.get("user", data.get("user", None)) or {} | |||
There was a problem hiding this comment.
Suggested change
| user_dict = data.get("user", data.get("user", None)) or {} | |
| user_dict = data.get("user") or {} |
snuba/datasets/errors_processor.py
Outdated
| @@ -46,8 +46,7 @@ def extract_custom( | |||
| metadata: KafkaMessageMetadata, | |||
| ) -> None: | |||
| data = event.get("data", {}) | |||
| user_dict = data.get("user", data.get("sentry.interfaces.User", None)) or {} | |||
|
|
|||
| user_dict = data.get("user", data.get("user", None)) or {} | |||
There was a problem hiding this comment.
Was this intentional?
The first version had a fallback to what appears to be an alternate key. This version checks for the same key twice.
There was a problem hiding this comment.
No, this is a mistake. Will revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I merged master I forgot to remove the duplicate Event type. Now there is only one and it has the right structure.