Hackweek: Added Makefile entry to fetch schema; eliminate type errors #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpacifici
approved these changes
Aug 4, 2020
|
|
||
| if isinstance(message, dict): | ||
| # deprecated unwrapped event message == insert | ||
| action_type = ProcessorAction.INSERT | ||
| try: | ||
|
|
| @@ -228,7 +234,7 @@ def process_insert( | |||
| self.extract_common(processed, event, metadata) | |||
| self.extract_custom(processed, event, metadata) | |||
|
|
|||
| sdk = data.get("sdk", None) or {} | |||
| sdk = data.get("sdk", None) or {} # type: ignore | |||
There was a problem hiding this comment.
What was the issue here ?
There was a problem hiding this comment.
"sdk" does not exists on the data object.
fpacifici
changed the title
dbennett-sentry
commented
Aug 4, 2020
| @@ -273,15 +283,15 @@ def extract_common( | |||
|
|
|||
| # Properties we get from the "data" dict, which is the actual event body. | |||
|
|
|||
| received = _collapse_uint32(int(data["received"])) | |||
| received = _collapse_uint32(data["received"]) | |||
There was a problem hiding this comment.
The extra int here is probably a bug as int(None) fails, _collapse_uint32(None) returns None, and the subsequent code checks for None
fpacifici
reviewed
Aug 4, 2020
| EventData = JSONSchema["schema/event.schema.json"] | ||
|
|
||
|
|
||
| class Event(TypedDict): |
There was a problem hiding this comment.
I think this class is duplicate of InsertEvent below. We should have only one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.