feat(uptime): Skip results from shadow regions in the result consumer #85711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we receive a result, we check the subscriptions regions and see if they're in shadow mode. If so, drop the result and log a stat.
github-actions
bot
added
the
Scope: Backend
wedamija
commented
Feb 22, 2025
Comment on lines
+267
to
+276
| @cache_func_for_models( | ||
| [(UptimeSubscriptionRegion, lambda region: (region.uptime_subscription_id,))], | ||
| recalculate=False, | ||
| ) | ||
| def get_regions_for_uptime_subscription( | ||
| uptime_subscription_id: int, | ||
| ) -> list[UptimeSubscriptionRegion]: | ||
| return list( | ||
| UptimeSubscriptionRegion.objects.filter(uptime_subscription_id=uptime_subscription_id) | ||
| ) |
There was a problem hiding this comment.
I'm going to add caches like this for other things we fetch, hoping it might improve performance here a little.
evanpurkhiser
approved these changes
Feb 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## danf/uptime-assign-shadow-regions #85711 +/- ##
=====================================================================
- Coverage 87.87% 87.86% -0.02%
=====================================================================
Files 9677 9672 -5
Lines 548104 547495 -609
Branches 21384 21384
=====================================================================
- Hits 481648 481030 -618
- Misses 66147 66156 +9
Partials 309 309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive a result, we check the subscriptions regions and see if they're in shadow mode. If so, drop the result and log a stat.