feat(releases): add release adoption table to insights #85702
+235
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michellewzhang
commented
Feb 21, 2025
michellewzhang
commented
- relates to Create Insights tables that show: Release Adoption & Release Health #84877
- add a release adoption table to frontend/backend & mobile insights
- mostly follows same format as the release health table and reuses the same hook/endpoint
github-actions
bot
added
the
Scope: Frontend
michellewzhang
commented
Feb 21, 2025
Comment on lines
+35
to
+45
|
|
||
| const currentDate = new Date(release.dateCreated); | ||
| const previousDate = | ||
| index < releases.length - 1 | ||
| ? new Date(releases[index + 1]?.dateCreated ?? 0) | ||
| : null; | ||
|
|
||
| const lifespan = previousDate | ||
| ? Math.floor(currentDate.getTime() - previousDate.getTime()) | ||
| : undefined; | ||
|
|
There was a problem hiding this comment.
lifespan is defined (by @ryan953 as the time difference between two releases)
michellewzhang
commented
Feb 21, 2025
Comment on lines
+88
to
+90
| ) : ( | ||
| '--' | ||
| ); |
There was a problem hiding this comment.
last lifespan in the table is rendered as -- since there's nothing previous to compare it to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.