alertlink: refactor to use composition #85700
Open
+362
−314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AlertLink to use the actual alert component and improve types. There are quite a few gotchas with this component and its types, and I expect there to be some unwanted behavior out there. This PR highlights all of those issues (see the number of todo comments) and addresses some.
Before:

After

Some, but not all issues include:
to
,href
andonClick
at the same time, not really knowing which one is used?onClick
is set, then a default value ofto='/'
is set, meaning event propagation likely has to be handled inside the onClick handler, else the navigation will still fire.