feat(workflow_engine): Schedule Deletion for Workflow #85665
Conversation
github-actions
bot
added
the
Scope: Backend
…flow and it's related models
saponifi3d
force-pushed
the
jcallender/aci/workflow-delete
branch
from
a5a0a77 to
f7d43c0
Compare
| from sentry.testutils.helpers import TaskRunner | ||
| from sentry.testutils.hybrid_cloud import HybridCloudTestMixin | ||
|
|
||
| # from tests.sentry.workflow_engine.test_base import BaseWorkflowTest |
There was a problem hiding this comment.
guessing you meant to remove this
| "action_condition", | ||
| ], | ||
| ) | ||
| def test_delete_workflow(self, instance_attr): |
There was a problem hiding this comment.
should we have a test with multiple actions?
There was a problem hiding this comment.
👍 also, woo! this comment made me realize i missed action in the test either 👀
|
Q: When an organization gets deleted, all of the organization's workflows get deleted. Will this task be triggered to clean up all of it's related models in that case? I'm thinking about the problem we discussed last week about actions not getting deleted when the org is deleted. |
@ameliahsu It doesn't seem like it -- locally, i added a test to confirm that the workflows are not cleaned up when you delete an org. we'd need to have a separate PR that's similar to this for the |
…d issue that sometimes the actions werent because of the roder of removal.
Description
Fix scheduled deletions for the
Workflowmodel - this will now ensure that all the subsequent models are cleaned up correctly.