ref(onboarding): Refactor onboarding components for rendering in drawer #85400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Feb 18, 2025
There was a problem hiding this comment.
Renamed sidebar.spec.tsx to this so that it directly tests the content.
Had to change some tests now that it uses the hook directly. Now it tests the actual tasks you'd see in prod which I think is better.
malwilley
commented
Feb 18, 2025
There was a problem hiding this comment.
This is mostly the same as what was in sidebar.tsx. Extracting so that it can be used in both the old sidebar panel and the new drawer hook.
malwilley
commented
Feb 18, 2025
| enabled: boolean; | ||
| supportedTasks: OnboardingTask[]; | ||
| }): { | ||
| export function useOnboardingTasks({disabled = false}: {disabled?: boolean} = {}): { |
There was a problem hiding this comment.
Simplified this hook a bit. It now gets the tasks list directly.
malwilley
commented
Feb 18, 2025
There was a problem hiding this comment.
Moved most of this into content.tsx
scttcper
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
For the new navigation, we want to move away from the old SidebarPanel and render elements in
useDrawer()instead.This refactor should have no behavioral changes. It simply extracts the onboarding content into a separate component that is consumed by both the legacy sidebar component as well as the new
useOnboardingWizardDrawer()