Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grouping): Update outdated grouphash metadata #85301

Draft
wants to merge 4 commits into
base: kmclb-add-schema-version-to-grouphash-metadata-table
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

When we first introduced grouphash metadata, we were only collecting it for new hashes. Then, we started adding it to existing hashes which were missing it. This represents the final part of the process: updating metadata for grouphashes which already have it if the data we collect has changed since we last did so. Like backfilling missing grouphash metadata, this is controlled by the grouping.grouphash_metadata.backfill_sample_rate option.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 14, 2025
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from afc8861 to bc38323 Compare February 18, 2025 20:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 18, 2025
@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from f7dca7f to c217cae Compare February 18, 2025 20:44
@lobsterkatie lobsterkatie removed the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 18, 2025
@getsentry getsentry deleted a comment from github-actions bot Feb 18, 2025
@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from c217cae to 4091f58 Compare February 18, 2025 22:44
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from bc38323 to 5dc91c6 Compare February 18, 2025 22:45
@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from 4091f58 to 467c959 Compare February 20, 2025 17:32
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from 5dc91c6 to 47e2b2b Compare February 20, 2025 17:32
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from 47e2b2b to d74c6b3 Compare February 20, 2025 17:37
@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from 467c959 to 5616bf8 Compare February 21, 2025 06:25
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from d74c6b3 to c18cd2d Compare February 21, 2025 06:25
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 73.97260% with 19 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/models/grouphashmetadata.py 13.63% 19 Missing ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           kmclb-add-schema-version-to-grouphash-metadata-table   #85301      +/-   ##
========================================================================================
+ Coverage                                                 84.75%   87.88%   +3.12%     
========================================================================================
  Files                                                      9673     9673              
  Lines                                                    547649   547722      +73     
  Branches                                                  21294    21294              
========================================================================================
+ Hits                                                     464168   481369   +17201     
+ Misses                                                    83172    66044   -17128     
  Partials                                                    309      309              

@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from 5616bf8 to 8eea882 Compare February 21, 2025 18:30
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from c18cd2d to f89c39b Compare February 21, 2025 18:30
@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from 8eea882 to f0a33e7 Compare February 22, 2025 01:14
@lobsterkatie lobsterkatie force-pushed the kmclb-add-schema-version-to-grouphash-metadata-table branch from f0a33e7 to 4e9e8e6 Compare February 22, 2025 01:21
@lobsterkatie lobsterkatie force-pushed the kmclb-update-grouphash-metadata-with-outdated-schema branch from f89c39b to f8cea1e Compare February 22, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant