-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grouping): Update outdated grouphash metadata #85301
Draft
lobsterkatie
wants to merge
4
commits into
kmclb-add-schema-version-to-grouphash-metadata-table
Choose a base branch
from
kmclb-update-grouphash-metadata-with-outdated-schema
base: kmclb-add-schema-version-to-grouphash-metadata-table
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(grouping): Update outdated grouphash metadata #85301
lobsterkatie
wants to merge
4
commits into
kmclb-add-schema-version-to-grouphash-metadata-table
from
kmclb-update-grouphash-metadata-with-outdated-schema
+239
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
afc8861
to
bc38323
Compare
f7dca7f
to
c217cae
Compare
c217cae
to
4091f58
Compare
bc38323
to
5dc91c6
Compare
4091f58
to
467c959
Compare
5dc91c6
to
47e2b2b
Compare
47e2b2b
to
d74c6b3
Compare
467c959
to
5616bf8
Compare
d74c6b3
to
c18cd2d
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## kmclb-add-schema-version-to-grouphash-metadata-table #85301 +/- ##
========================================================================================
+ Coverage 84.75% 87.88% +3.12%
========================================================================================
Files 9673 9673
Lines 547649 547722 +73
Branches 21294 21294
========================================================================================
+ Hits 464168 481369 +17201
+ Misses 83172 66044 -17128
Partials 309 309 |
5616bf8
to
8eea882
Compare
c18cd2d
to
f89c39b
Compare
8eea882
to
f0a33e7
Compare
f0a33e7
to
4e9e8e6
Compare
f89c39b
to
f8cea1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first introduced grouphash metadata, we were only collecting it for new hashes. Then, we started adding it to existing hashes which were missing it. This represents the final part of the process: updating metadata for grouphashes which already have it if the data we collect has changed since we last did so. Like backfilling missing grouphash metadata, this is controlled by the
grouping.grouphash_metadata.backfill_sample_rate
option.