Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav): Use drawer for profiling onboarding #85297

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

malwilley
Copy link
Member

Ref #84018

The old navigation sidebar has been the component responsible for displaying the onboarding panels. Since we are moving to a new nav component, I'm going to be moving all the existing onboarding panels over to useDrawer().

@malwilley malwilley requested a review from a team as a code owner February 14, 2025 23:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 14, 2025
@malwilley malwilley requested a review from a team February 14, 2025 23:08
Copy link

codecov bot commented Feb 18, 2025

Bundle Report

Changes will increase total bundle size by 168.69kB (0.51%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.08MB 168.69kB (0.51%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/app_bootstrap_initializeApp_tsx-app_components_avatar_actorAvatar_tsx-app_components_avatar_a-7c38cc.*.js 370 bytes 1.4MB 0.03%
chunks/app_components_assigneeBadge_tsx-app_components_badge_featureBadge_tsx-app_components_charts_-643f8b.*.js 204 bytes 1.13MB 0.02%
chunks/app_actionCreators_redirectToProject_tsx-app_bootstrap_commonInitialization_tsx-app_bootstrap-bd01b6.*.js (New) 444.43kB 444.43kB 100.0% 🚀
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx-app_views_issueDetails_streaml-b468ad.*.js -1.33kB 390.71kB -0.34%
chunks/app_actionCreators_preferences_tsx-app_components_avatar_actorAvatar_tsx-app_components_chevr-05b9bf.*.js 547 bytes 311.89kB 0.18%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-5dfcad.d44a3410ced0b1f9ff40.js (New) 281.41kB 281.41kB 100.0% 🚀
chunks/app_actionCreators_discoverHomepageQueries_tsx-app_components_lazyRender_tsx-app_components_n-5e5ad0.*.js -938 bytes 170.84kB -0.55%
chunks/app_views_traces_content_tsx-node_modules_core-js_modules_es_array_to-spliced_js.*.js (New) 128.65kB 128.65kB 100.0% 🚀
chunks/app_data_timezones_tsx-app_utils_useUserTeams_tsx-app_views_alerts_builder_builderBreadCrumbs-f50fa4.*.js 21 bytes 112.86kB 0.02%
chunks/app_components_charts_eventsRequest_tsx-app_utils_routeAnalytics_useRouteAnalyticsEventNames_-3be7f3.*.js -38 bytes 108.14kB -0.04%
chunks/app_components_alert_stories_tsx.*.js 97.47kB 107.98kB 926.75% ⚠️
entrypoints/app.js 156 bytes 99.02kB 0.16%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.5cde7ad8add4807d7938.js (New) 95.24kB 95.24kB 100.0% 🚀
chunks/app_components_search_index_tsx.*.js -2 bytes 71.35kB -0.0%
chunks/app_views_profiling_profileSummary_index_tsx-node_modules_react-virtualized_dist_es_CellMeasu-a35cf7.*.js 233 bytes 66.5kB 0.35%
chunks/app_components_charts_components_markArea_tsx-app_components_charts_eventsRequest_tsx-app_vie-b7a407.*.js 44 bytes 62.78kB 0.07%
chunks/app_views_settings_dynamicSampling_index_tsx-node_modules_react-virtualized_dist_es_CellMeasu-6b1be5.*.js -2 bytes 48.94kB -0.0%
chunks/app_views_explore_components_typeBadge_tsx-app_views_explore_multiQueryMode_index_tsx.*.js (New) 42.95kB 42.95kB 100.0% 🚀
chunks/app_views_alerts_list_rules_alertRulesList_tsx-node_modules_react-virtualized_dist_es_CellMea-2d6856.*.js 90 bytes 39.64kB 0.23%
chunks/app_views_alerts_wizard_index_tsx-node_modules_react-virtualized_dist_es_CellMeasurer_CellMea-4ae9b7.*.js 41 bytes 38.26kB 0.11%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.987cde1e480e847ea5cb.js (New) 37.35kB 37.35kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.f0efd893486352f0b94d.js (New) 31.68kB 31.68kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.cec27ed33232a5d98e00.js (New) 31.18kB 31.18kB 100.0% 🚀
chunks/app_views_alerts_rules_issue_details_ruleDetails_tsx.*.js 43 bytes 30.86kB 0.14%
chunks/app_views_alerts_filterBar_tsx-app_views_alerts_list_header_tsx.*.js -18 bytes 30.71kB -0.06%
chunks/app_actionCreators_members_tsx-app_components_acl_access_tsx-app_components_deprecatedAsyncCo-33caf4.*.js (New) 29.1kB 29.1kB 100.0% 🚀
chunks/app_gettingStartedDocs_java_spring_tsx.*.js 718 bytes 27.46kB 2.69%
chunks/app_views_alerts_rules_uptime_details_tsx-node_modules_react-virtualized_dist_es_CellMeasurer-6d1558.*.js 44 bytes 27.22kB 0.16%
chunks/app_components_onboarding_gettingStartedDoc_sdkDocumentation_tsx-app_components_onboarding_us-035896.*.js 182 bytes 26.32kB 0.7%
chunks/app_gettingStartedDocs_java_spring-boot_tsx.*.js 720 bytes 25.44kB 2.91%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.d731ae1a132e7df9afa0.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_gettingStartedDocs_android_android_tsx.*.js 589 bytes 22.79kB 2.65%
chunks/app_views_insights_pages_backend_backendOverviewPage_tsx.*.js 4.67kB 22.76kB 25.79% ⚠️
chunks/app_gettingStartedDocs_java_logback_tsx.*.js 937 bytes 20.45kB 4.8%
chunks/app_gettingStartedDocs_java_log4j2_tsx.*.js 520 bytes 19.62kB 2.72%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.8a4770ab63af242548d3.js (New) 17.29kB 17.29kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.2e920c7cdcfec94ebb7f.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_views_explore_hooks_useSortByFields_tsx-app_views_explore_hooks_useTopEvents_tsx-app_view-c29ecd.*.js (New) 14.46kB 14.46kB 100.0% 🚀
chunks/app_views_projectInstall_platformOrIntegration_tsx.*.js -465 bytes 14.36kB -3.14%
chunks/app_components_feedback_widget_feedbackWidgetButton_tsx-app_components_profiling_profilingBre-60e72d.*.js 645 bytes 14.32kB 4.72%
chunks/SetupWizard.*.js 18 bytes 13.95kB 0.13%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.127526b6dc5f5a13ed48.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_actionCreators_projects_tsx-app_actionCreators_teams_tsx-app_components_hookOrDefault_tsx-c4ddaf.*.js (New) 12.86kB 12.86kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.2e1aed2ac91f8dd53bef.js (New) 12.32kB 12.32kB 100.0% 🚀
chunks/app_gettingStartedDocs_node_nestjs_tsx.*.js 39 bytes 11.43kB 0.34%
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-1148da.*.js (New) 10.42kB 10.42kB 100.0% 🚀
chunks/app_gettingStartedDocs_java_java_tsx.*.js 344 bytes 10.17kB 3.5%
chunks/app_stories_storyBook_tsx.*.js 165 bytes 10.0kB 1.68%
chunks/app_actionCreators_discoverHomepageQueries_tsx-app_components_modals_dashboardWidgetQuerySele-d3d203.*.js -353 bytes 9.61kB -3.54%
chunks/app_views_alerts_edit_tsx.*.js 28 bytes 7.21kB 0.39%
chunks/app_views_alerts_create_tsx.*.js 36 bytes 7.11kB 0.51%
chunks/app_views_alerts_rules_uptime_existingOrCreate_tsx.*.js -8 bytes 2.9kB -0.28%
chunks/app_views_alerts_builder_projectProvider_tsx.*.js 43 bytes 2.44kB 1.79%
chunks/app_actionCreators_redirectToProject_tsx-app_bootstrap_commonInitialization_tsx-app_bootstrap-9446db.*.js (Deleted) -443.83kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-5dfcad.6e6d68aebd12518ae348.js (Deleted) -281.42kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_database_utils_getIntervalForMetricFunction_tsx-app_views_traces_content_tsx.*.js (Deleted) -98.02kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.cd3084a425c1a7bfd5ec.js (Deleted) -95.24kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.7bbd66c884dc0d08ef3d.js (Deleted) -37.35kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.80288450017fcb39cc44.js (Deleted) -31.68kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--fbb1b9.b6495b10d283fd7842a2.js (Deleted) -31.18kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_members_tsx-app_components_acl_access_tsx-app_components_deprecatedAsyncCo-f0ff70.*.js (Deleted) -29.7kB 0 bytes -100.0% 🗑️
chunks/app_views_explore_multiQueryMode_index_tsx.*.js (Deleted) -25.47kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.fdabb441668728fe87da.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.be718fc367f02ee90e05.js (Deleted) -17.29kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.4ba9be3af6e78f2653c0.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_projects_tsx-app_actionCreators_teams_tsx-app_components_hookOrDefault_tsx-bc1963.*.js (Deleted) -13.44kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.84e92e6267d2e19f9a0b.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.f244b26e97464cad3133.js (Deleted) -12.32kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_echarts_lib_chart_scatter_js-node_modules_echarts_lib_component_dataZoom-266d60.*.js (Deleted) -9.47kB 0 bytes -100.0% 🗑️

@malwilley malwilley merged commit 142494f into master Feb 18, 2025
42 checks passed
@malwilley malwilley deleted the malwilley/feat/nav-onboarding-profiling branch February 18, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants