cleanup(metrics): remove snuba tag value meta table references #85193
+13
−563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #85193 +/- ##
==========================================
- Coverage 87.97% 87.97% -0.01%
==========================================
Files 9627 9623 -4
Lines 543534 543620 +86
Branches 21039 21039
==========================================
+ Hits 478195 478270 +75
- Misses 65033 65044 +11
Partials 306 306 |
JoshFerge
approved these changes
Feb 13, 2025
nikhars
approved these changes
Feb 13, 2025
onkar
approved these changes
Feb 13, 2025
|
note for later: we should remove |
onewland
added a commit
to getsentry/snuba
that referenced
this pull request
Feb 14, 2025
#6883) This reverts commit 2dea118 and reinstates #6878 now that Sentry should no longer have dependencies on this table: getsentry/sentry#85193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tag values tables aren't being accessed and we want to stop writing to this table to reduce load on the generic-metrics-distributions cluster in SaaS (see INC-1035)
(not making this change broke integration tests when I tried to merge getsentry/snuba#6878 and that had to be reverted)