Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav): Update alerts links to /issues/alerts/ #85005

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

malwilley
Copy link
Member

Ref #84018

The new nav structure moves /alerts/ to /issues/alerts/.

To facilitate the transition, I'm adding a util makeAlertsPathname() that will check a feature flag to decide which link to generate.

@malwilley malwilley requested review from a team as code owners February 11, 2025 21:37
@malwilley malwilley removed request for a team February 11, 2025 21:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 11, 2025
@malwilley malwilley force-pushed the malwilley/feat/nav-alerts-links branch from 13bf721 to 7e7450f Compare February 11, 2025 21:39
Copy link

codecov bot commented Feb 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8480 1 8479 3
View the top 1 failed test(s) by shortest run time
CreateAlertFromViewButton redirects to alert wizard with no project
Stack Traces | 0.041s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: ".../org-slug/alerts/wizard/", ObjectContaining {"params": ObjectContaining {"orgId": "org-slug"}}
Received: ".../org-slug/alerts/wizard/?", {"createHref": [Function mockConstructor], "createPath": [Function mockConstructor], "go": [Function mockConstructor], "goBack": [Function mockConstructor], "goForward": [Function mockConstructor], "isActive": [Function mockConstructor], "location": {"action": "PUSH", "hash": "", "key": "", "pathname": "/mock-pathname/", "query": {}, "search": "", "state": null}, "params": {"orgId": "org-slug", "projectId": "project-slug"}, "push": [Function mockConstructor], "replace": [Function mockConstructor], "routes": [], "setRouteLeaveHook": [Function mockConstructor]}

Number of calls: 1
    at Object.<anonymous> (.../app/components/createAlertButton.spec.tsx:203:36)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@malwilley malwilley merged commit fbc5110 into master Feb 13, 2025
42 checks passed
@malwilley malwilley deleted the malwilley/feat/nav-alerts-links branch February 13, 2025 18:58
@gaprl gaprl added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Feb 14, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 34bd16d

getsentry-bot added a commit that referenced this pull request Feb 14, 2025
@gaprl
Copy link
Member

gaprl commented Feb 14, 2025

Reverting as this has broken accessing uptime monitors from back-end insights: https://github.com/getsentry/sentry/pull/85005/files#diff-7edef5f8c8223b8140546bcc13f7b9184e14fe27e725d13d2aa327610b76adfaR55-R58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants