feat(nav): Display secondary nav in mobile menu #84582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Feb 5, 2025
Comment on lines
44
to
55
| const value = useMemo( | ||
| () => ({secondaryNavEl, setSecondaryNavEl}), | ||
| [secondaryNavEl, setSecondaryNavEl] | ||
| () => ({ | ||
| secondaryNavEl, | ||
| setSecondaryNavEl, | ||
| layout: isMobile ? NavLayout.MOBILE : NavLayout.SIDEBAR, | ||
| isCollapsed, | ||
| setIsCollapsed, | ||
| activeGroup, | ||
| setActiveGroup, | ||
| }), | ||
| [secondaryNavEl, isMobile, isCollapsed, setIsCollapsed, activeGroup] | ||
| ); |
There was a problem hiding this comment.
I always wrap context values in useMemo to prevent every consumer of the context from rerendering if this component does. Though since the context is near the top of the render tree it probably doesn't matter much
scttcper
approved these changes
Feb 5, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
- Adds the secondary nav menu to the mobile menu when you first tap the hamburger menu - In order to display the header title, adds `activeGroup` state to the navigation context (also need to add a prop to `<SecondaryNavigation />` and update callsites - Adds `layout` to the nav context so components can render differently based on the current layout (mobile or sidebar)
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
activeGroupstate to the navigation context (also need to add a prop to<SecondaryNavigation />and update callsiteslayoutto the nav context so components can render differently based on the current layout (mobile or sidebar)Before:
After:
CleanShot.2025-02-04.at.15.56.50.mp4