feat(nav): Use new secondary nav in settings #84331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 40.41kB (0.12%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
|
malwilley
commented
Jan 30, 2025
There was a problem hiding this comment.
Not a new file, renamed settingsNavItem -> settingsNavItemDeprecated
malwilley
commented
Jan 30, 2025
There was a problem hiding this comment.
Not a new file, renamed settingsNavigationGroup -> settingsNavigationGroupDeprecated
scttcper
approved these changes
Jan 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
This PR duplicates existing components which render the settings navigation sidebar so that, when the feature flag is enabled, they instead render the new
<SecondaryNav />components.There are still a few bugs that need to be ironed out, but for now the correct items are being rendered from the existing config.