Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): Add thread navigators, compact dropdown #80969

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Nov 19, 2024

  • Switch from dropdown autocomplete to compact select. Can more easily tell which one is selected.
  • add next/previous thread navigation

part of #60438
fixes #20746

before

image

after
image

- Switch from dropdown autocomplete to compact select
- add next/previous thread navigation
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 20 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...events/interfaces/threads/threadSelector/index.tsx 65.51% 10 Missing ⚠️
...tatic/app/components/events/interfaces/threads.tsx 75.00% 4 Missing ⚠️
...rfaces/threads/threadSelector/filterThreadInfo.tsx 0.00% 3 Missing ⚠️
...vents/interfaces/threads/threadSelector/option.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80969      +/-   ##
==========================================
+ Coverage   71.04%   78.49%   +7.44%     
==========================================
  Files        7206     7206              
  Lines      319239   319322      +83     
  Branches    43941    43947       +6     
==========================================
+ Hits       226818   250645   +23827     
+ Misses      85334    62295   -23039     
+ Partials     7087     6382     -705     

@scttcper scttcper marked this pull request as ready for review November 19, 2024 18:38
@scttcper scttcper requested a review from a team November 19, 2024 21:07
@scttcper scttcper merged commit aa58942 into master Nov 20, 2024
45 checks passed
@scttcper scttcper deleted the scttcper/thread-selector branch November 20, 2024 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add next and previous thread buttons
3 participants