ref(routes): Simplify routing tree using custom route builder #66747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-routes-introduce-helper-route-in-routes-tsx
branch
from
7ac115c to
0e0d3b5
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-routes-introduce-helper-route-in-routes-tsx
branch
2 times, most recently
from
fcab9d3 to
6eabc82
Compare
evanpurkhiser
commented
Mar 12, 2024
static/app/routes.tsx
Outdated
| /> | ||
| </Route> | ||
| </Fragment> | ||
| <Route path="/release-thresholds/" withLegacyPath> |
There was a problem hiding this comment.
In this case the NoOp component is not required and will be added as needed.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-routes-introduce-helper-route-in-routes-tsx
branch
from
6eabc82 to
e6b1208
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-routes-introduce-helper-route-in-routes-tsx
branch
from
e6b1208 to
1e2b685
Compare
evanpurkhiser
changed the title
gggritso
approved these changes
Mar 12, 2024
Comment on lines
+204
to
+206
| // When adding new top-level organization routes, be sure the top level | ||
| // route includes withOrgPath to support installs that are not using | ||
| // customer domains. |
There was a problem hiding this comment.
If this is really important (which it is) might be worth making a component called TopLevelRoute and another called Route so this error is harder to make
There was a problem hiding this comment.
that's not a bad idea 👍
static/app/routes.tsx
Outdated
| // traversing the component tree, that is why this logic lives here and not | ||
| // inside a custom Route component. | ||
| // | ||
| // To udnerstand deepr how thsi works, see [0]. |
There was a problem hiding this comment.
Suggested change
| // To udnerstand deepr how thsi works, see [0]. | |
| // To understand deeper how this works, see [0]. |
This helps reduce the current complexity of reading the route tree. We have many route sub-trees that have conditional checks to be
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-routes-introduce-helper-route-in-routes-tsx
branch
from
1e2b685 to
816c56d
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-routes-introduce-helper-route-in-routes-tsx
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce the current complexity of reading the route tree by introducing some logic which builds the two org and orgless routes from a single route.
This only changes the simplest cases. There are a number of more complicated routes that can also be simplified that I will do in a follow up.