fix(hybridcloud) Fix cross-silo query in project rule details #61435
+87
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In project rule details we hydrate a detached SentryAppInstallation record to shim up ui component behavior. Preparing ui components requires going from the install to sentryapp which emits a cross silo query in test silos. We haven't been able to catch this in tests before because we don't patch association properties. To get this working I've hydrated a detached SentryApp record. The entire prepare_ui component flow needs to be rebuilt with Rpc models to remove this cruft and that is a bigger undertaking than we have time for today. Fixes HC-1023
github-actions
bot
added
the
Scope: Backend
markstory
added a commit
that referenced
this pull request
Dec 8, 2023
There are two sentryapp API endpoints (requests/interactions) that store data in the creating org's region. These endpoints need to be proxied to the region where the sentryapp was created for now. I found this while working on #61435 Refs HC-1023
corps
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Alternatively, we did discuss refactoring the modeling of SentryApps, with region replicated "summary" models that put the relevant stuff together, too.
Honestly, I favor thinking refactoring SentryApp modeling because there are many, problems with its current design that mostly just require aggregating the modeling into a simpler design.
But I agree that's not your work for now.
This is the path I want to take as well, but it requires building new RPC model based code paths first. |
markstory
added a commit
that referenced
this pull request
Dec 8, 2023
There are two sentryapp API endpoints (requests/interactions) that store data in the creating org's region. These endpoints need to be proxied to the region where the sentryapp was created for now. I found this while working on #61435 Refs HC-1023
dashed
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In project rule details we hydrate a detached SentryAppInstallation record to shim up ui component behavior. Preparing ui components requires going from the install to sentryapp which emits a cross silo query in test silos. We haven't been able to catch this in tests before because we don't patch association properties.
To get this working I've hydrated a detached SentryApp record. The entire prepare_ui component flow needs to be rebuilt with Rpc models to remove this cruft and that is a bigger undertaking than we have time for today. I've ticketed the follow up work for us to complete later.
Fixes HC-1023