Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Feedback] Feedback widget is no longer collecting name or email #70347

Closed
michellewzhang opened this issue May 6, 2024 · 2 comments · Fixed by getsentry/sentry-javascript#11993
Closed

[User Feedback] Feedback widget is no longer collecting name or email #70347

michellewzhang opened this issue May 6, 2024 · 2 comments · Fixed by getsentry/sentry-javascript#11993
Assignees
@c298lee

Comments

@michellewzhang
Copy link
Member

michellewzhang commented May 6, 2024 •
edited by ryan953
Loading

Can see that all of the labels say "anonymous" (which means on the frontend we don't have access to a name or email to display):

328232263-8b0ec5f6-b400-4c76-bc31-86f4c78bd1cf
@michellewzhang michellewzhang changed the title [User Feedback] Feedback widget is no longer ingesting name or email [User Feedback] Feedback widget is no longer collecting name or email May 6, 2024
@c298lee
Copy link
Contributor

c298lee commented May 6, 2024

This is happening because getCurrentScope().getUser() isn't returning anything. Waiting on Francesco for how to best access the scope to fix this.

@c298lee c298lee self-assigned this May 6, 2024
@c298lee
Copy link
Contributor

c298lee commented May 7, 2024

fixed with getsentry/sentry-javascript#11928

@c298lee c298lee closed this as completed May 7, 2024
@c298lee c298lee mentioned this issue May 13, 2024
Merged
c298lee added a commit to getsentry/sentry-javascript that referenced this issue May 13, 2024
@c298lee
fix(feedback): Check for empty user (#11993)
1098627 
When getting the user from the scope, the user can also be an empty
object, which doesn't work with null coalescing. This checks to see if
the user exists and that it's not empty in all scopes

Fixes getsentry/sentry#70347
andreiborza pushed a commit to getsentry/sentry-javascript that referenced this issue May 16, 2024
@c298lee @andreiborza
fix(feedback): Check for empty user (#11993)
77e6820 
When getting the user from the scope, the user can also be an empty
object, which doesn't work with null coalescing. This checks to see if
the user exists and that it's not empty in all scopes

Fixes getsentry/sentry#70347
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@c298lee c298lee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(feedback): Check for empty user getsentry/sentry-javascript
2 participants
@c298lee @michellewzhang