Skip to content

Commit

Permalink
fix(traces): change span cta and fixed css alignment' (#72878)
Browse files Browse the repository at this point in the history
  • Loading branch information
doralchan authored Jun 17, 2024
1 parent 15926b9 commit a9c1599
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
4 changes: 2 additions & 2 deletions static/app/utils/analytics/tracingEventMap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ export const tracingEventMap: Record<TracingEventKey, string | null> = {
'trace.trace_layout.view_similar_spans': 'View Similar Spans in Trace',
'trace.trace_layout.view_span_summary': 'View Span Summary in Trace',
'trace.trace_layout.span_row_click': 'Clicked Span Row in Trace',
'trace_explorer.add_span_condition': 'Trace Explorer: Add Span Condition',
'trace_explorer.add_span_condition': 'Trace Explorer: Add Another Span',
'trace_explorer.open_in_issues': 'Trace Explorer: Open Trace in Issues',
'trace_explorer.open_trace': 'Trace Explorer: Open Trace in Trace Viewer',
'trace_explorer.open_trace_span': 'Trace Explorer: Open Trace Span in Trace Viewer',
'trace_explorer.remove_span_condition': 'Trace Explorer: Remove Span Condition',
'trace_explorer.remove_span_condition': 'Trace Explorer: Remove Span',
'trace_explorer.toggle_trace_details': 'Trace Explorer: Toggle Trace Details in Table',
'trace_explorer.search_failure': 'Trace Explorer: Search Failure',
'trace_explorer.search_request': 'Trace Explorer: Search Request',
Expand Down
8 changes: 3 additions & 5 deletions static/app/views/traces/tracesSearchBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function TracesSearchBar({
projectIds={ALL_PROJECTS}
/>
<StyledButton
aria-label={t('Remove span')}
aria-label={t('Remove Span')}
icon={<IconClose size="sm" />}
size="sm"
onClick={() => {
Expand All @@ -77,7 +77,7 @@ export function TracesSearchBar({

{canAddMoreQueries ? (
<Button
aria-label={t('Add query')}
aria-label={t('Add Query')}
icon={<IconAdd size="xs" isCircled />}
size="sm"
onClick={() => {
Expand Down Expand Up @@ -105,21 +105,19 @@ const TraceSearchBarsContainer = styled('div')`
const TraceBar = styled('div')`
display: flex;
flex-direction: row;
align-items: center;
justify-content: flex-start;
width: 100%;
gap: ${space(1)};
`;

const SpanLetter = styled('div')`
background-color: ${p => p.theme.purple100};
border-radius: ${p => p.theme.borderRadius};
padding: ${space(1)} ${space(2)};
text-align: center;
min-width: 220px;
color: ${p => p.theme.purple400};
white-space: nowrap;
font-weight: ${p => p.theme.fontWeightBold};
align-content: center;
`;

const StyledSearchBar = styled(SearchBar)`
Expand Down

0 comments on commit a9c1599

Please sign in to comment.